Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canadian English formats patch #3844

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Canadian English formats patch #3844

merged 4 commits into from
Jan 30, 2024

Conversation

candideu
Copy link
Contributor

@candideu candideu commented Jan 29, 2024

Ref: #3842

I understand that I need to make sure to have provisions for this PR, but I'm not sure what that entails. Please let me know what else needs to be added or done, and I'll update this PR.

I'll create a PR for Django later. It looks like they already have a format for Canadian French, which is great!

Related Django PR: django/django#17794

Copy link

cla-bot bot commented Jan 29, 2024

Hey there! :) Thank you very much for offering a contribution to pretix! For legal reasons, we need you to sign a Contributor License Agreement in order to be able to merge the code. Sorry for the hassle :( Please download the agreement from https://pretix.eu/about/en/cla and send a signed copy to support@pretix.eu. Feel free to also contact us there or via comments here if you have any questions!

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Merging #3844 (0cd2cdb) into master (31392e5) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 0cd2cdb differs from pull request most recent head 784084e. Consider uploading reports for the commit 784084e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3844      +/-   ##
==========================================
- Coverage   78.08%   78.07%   -0.01%     
==========================================
  Files         426      427       +1     
  Lines       59346    59335      -11     
==========================================
- Hits        46338    46325      -13     
- Misses      13008    13010       +2     
Files Coverage Δ
src/pretix/helpers/formats/en_CA/formats.py 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Copy link

cla-bot bot commented Jan 30, 2024

Hey there! :) Thank you very much for offering a contribution to pretix! For legal reasons, we need you to sign a Contributor License Agreement in order to be able to merge the code. Sorry for the hassle :( Please download the agreement from https://pretix.eu/about/en/cla and send a signed copy to support@pretix.eu. Feel free to also contact us there or via comments here if you have any questions!

Copy link

cla-bot bot commented Jan 30, 2024

Hey there! :) Thank you very much for offering a contribution to pretix! For legal reasons, we need you to sign a Contributor License Agreement in order to be able to merge the code. Sorry for the hassle :( Please download the agreement from https://pretix.eu/about/en/cla and send a signed copy to support@pretix.eu. Feel free to also contact us there or via comments here if you have any questions!

@raphaelm raphaelm merged commit f97ad66 into pretix:master Jan 30, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants