Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sentry-sdk requirement from ==1.45.* to ==2.5.* #4176

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Conversation

raphaelm
Copy link
Member

@raphaelm raphaelm commented May 24, 2024

  • Replacing our custom scrubbing code with the new official one
  • Removing cookie transmission as we do not have any interesting cookies that are not scrubbed anyways, so it provides no real value and only risk of data leaks

@cla-bot cla-bot bot added the cla-signed label May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.15%. Comparing base (8bc16af) to head (0c6065d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4176      +/-   ##
==========================================
+ Coverage   78.10%   78.15%   +0.04%     
==========================================
  Files         430      430              
  Lines       60550    60512      -38     
==========================================
  Hits        47294    47294              
+ Misses      13256    13218      -38     
Files Coverage Δ
src/pretix/sentry.py 0.00% <ø> (ø)

self.denylist += [
"access_token",
"sentry_dsn",
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
]
]
self.recursive = True

...sonst scheint er nur top-level-keys zu filtern, und wir sind ja bisher rekursiv unterwegs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eigentlich können wir uns den eigenen PretixEventScrubber auch sparen und einfach wie in der doku nur eine eigene denylist definieren und den EventScrubber direkt nutzen

from sentry_sdk.scrubber import EventScrubber, DEFAULT_DENYLIST
        # custom denylist
        pretix_denylist = DEFAULT_DENYLIST + [
            "access_token",
            "sentry_dsn",
        ]
        sentry_sdk.init(
            # ...
            event_scrubber=EventScrubber(denylist=pretix_denylist, recursive=True),

@raphaelm raphaelm changed the title Update sentry-sdk requirement from ==1.45.* to ==2.3.* Update sentry-sdk requirement from ==1.45.* to ==2.5.* Jun 10, 2024
@raphaelm raphaelm merged commit ab576bb into master Jun 10, 2024
12 checks passed
@raphaelm raphaelm deleted the sentry-2 branch June 10, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants