Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #53 -- Add add-on products #435

Merged
merged 3 commits into from Apr 17, 2017
Merged

Fix #53 -- Add add-on products #435

merged 3 commits into from Apr 17, 2017

Conversation

raphaelm
Copy link
Member

@raphaelm raphaelm commented Mar 18, 2017 •
edited

  • Data model
  • Control configuration UI
  • Cart handling and UI
    • Choice form
    • Cart manipulation
    • Drop min_count constraint if sold out?
    • Free price support? – not for now
    • Quota checks in Form
    • Quota checks in CartManager
    • Display differing tax rates
    • Voucher required, Hide without voucher
    • Sorting for questions UI
    • is_completed
    • Delete correct position if depended position is deleted
    • Error message localization
    • Constraint check at order time
    • Forbid adding an add-on product as a standalone item
    • Hide items from index and voucher redemption page
    • Display/ordering on invoices
    • Ticket download options, checkin
    • Show descriptions
  • Cart display UI
  • Order display UI (presale)
  • Order display UI (control)
  • Order change form
  • Order user-modify form
  • Prevent or handle vouchers for add-ons
  • Optional: Make add-on products free even if they have prices
  • Make code more understandable
  • Waiting list? – NOPE
  • Ignore for max items in order
  • Extensive tests
  • i18n

@raphaelm raphaelm self-assigned this Mar 18, 2017
@raphaelm raphaelm force-pushed the addon-products branch 3 times, most recently from 4589eb1 to 956e13e Compare March 19, 2017 14:21
@codecov
Copy link

codecov bot commented Mar 19, 2017 •
edited

Codecov Report

Merging #435 into master will increase coverage by 0.34%.
The diff coverage is 90.23%.

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   80.29%   80.63%   +0.34%     
==========================================
  Files         166      165       -1     
  Lines       11090    11394     +304     
==========================================
+ Hits         8905     9188     +283     
- Misses       2185     2206      +21
Impacted Files Coverage Δ
src/pretix/base/exporters/mail.py 76.19% <ø> (ø) ⬆️
src/pretix/presale/views/event.py 83.96% <ø> (ø) ⬆️
src/pretix/base/exporters/json.py 84.61% <ø> (ø) ⬆️
src/pretix/base/settings.py 100% <ø> (ø) ⬆️
src/pretix/control/logdisplay.py 39.62% <ø> (ø) ⬆️
src/pretix/base/ticketoutput.py 75% <0%> (-3.95%) ⬇️
src/pretix/plugins/ticketoutputpdf/ticketoutput.py 87.09% <0%> (-1.43%) ⬇️
src/pretix/plugins/checkinlists/exporters.py 0% <0%> (ø) ⬆️
src/pretix/base/models/orders.py 95.13% <100%> (+0.09%) ⬆️
src/pretix/plugins/pretixdroid/views.py 90.36% <100%> (ø) ⬆️
... and 23 more

@raphaelm raphaelm modified the milestone: 1.2.0 Mar 24, 2017
@raphaelm raphaelm added this to the 1.3.0 milestone Apr 10, 2017
@raphaelm raphaelm force-pushed the addon-products branch 4 times, most recently from a94ae65 to b0f5ac2 Compare April 14, 2017 14:57
@raphaelm raphaelm merged commit b52f2f5 into master Apr 17, 2017
@raphaelm raphaelm deleted the addon-products branch April 17, 2017 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@raphaelm raphaelm

Labels
pr status: needs improvement
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@raphaelm