upgrade dependencies to fix npm audit warnings #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
request is deprecated, update to node-fetch (2.x only, commonjs) update private `requestData` function to use request instead
preparation step in removing gulp
install latest jshint explicitly and add script to run it can later replace/fix more lint issues preparation step in removing gulp
can use `npm run lint` to lint and `npm test` to test. this removes watching for changes to auto lint/test this fixes most of the critical npm vulnerabilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace
gulp:install latest
jshintandmochadirectly. add npm script to run lint. remove gulp file and dependencies (old packages. not upgrading since part of #1 is to remove)replace
requestwithnode-fetch:requestis deprecated, and there were vulnerabilities on this. replace withnode-fetchand update usage (private function only)update
nock:fixes
npm auditvulnerabilitybreaking change only in dev (
gulp watchnot replaced)see #1