avoid splitting parentheses of a function call without arguments #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
- Coverage 97.73% 97.32% -0.42%
==========================================
Files 66 66
Lines 441 448 +7
Branches 57 58 +1
==========================================
+ Hits 431 436 +5
- Misses 10 12 +2
Continue to review full report at Codecov.
|
fvictorio
approved these changes
Jun 7, 2019
| } | ||
| if (node.arguments && node.arguments.length > 0) { |
There was a problem hiding this comment.
This doesn't come from this PR, but I'm curious. When does a function call have "names" and when does it have "arguments"?
There was a problem hiding this comment.
Will have to double check this one but from the look of the output code, a function call has names when is initializing a struct.
struct FooStruct {
uint foo;
uint figther;
}
FooStruct myStruct = FooStruct({foo:1, fighter:2});
|
you can rebase now |
Janther
force-pushed
the
bugfix/function_call_without_arguments
branch
from
324d5a4
to
999ece2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
halfway fixing #115
still working on splitting function calls on the
.character.