update-deps

[mattiaerre]

Description

• update dependencies

[codecov]

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          74       74           
  Lines         544      544           
  Branches       76       76           
=======================================
  Hits          536      536           
  Misses          8        8

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e9100...d9e7112. Read the comment docs.

[Janther]

I downgraded the versions of these packages to support node 6

Package	Current	Wanted	Latest
escape-string-regexp	1.0.5	1.0.5	2.0.0
eslint	5.16.0	5.16.0	6.0.1
string-width	3.1.0	3.1.0	4.1.0

If we want to upgrade these we will have to stop supporting node 6 in our travis config.

[mattiaerre]

@Janther yes I've noticed that that was the problem, I'm down to stop supporting node 6 tbh, what do you think?

[Janther]

It’s very tricky to decide which versions to use. In my own projects I tend to use always the latest versions of packages but in an open source one we might want to keep using older ones as long as we don’t find a critical issue. Anyway at the moment we don’t have much info on how much this tool is being used and in which scenarios. I recon it’s used in new versions of node only. I would add an `engines` attribute in our `package.json` if we are not gonna support a node version.

…

On Wed, 3 Jul 2019 at 12:39 PM, mattia richetto ***@***.***> wrote: @Janther <https://github.com/Janther> yes I've noticed that that was the problem, I'm down to stop supporting node 6 tbh, what do you think? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#169?email_source=notifications&email_token=AAHZQZXY55BXDA53FYGBVHTP5PYM5A5CNFSM4H4CORJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZC5RLQ#issuecomment-507893934>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHZQZSSK7RPN2PUZHDOKKDP5PYM5ANCNFSM4H4CORJQ> .

[mattiaerre]

Yeah, I agree. let's do this 👍