Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

braket spacing and indenting in import directives #177

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

Janther
Copy link
Contributor

@Janther Janther commented Jul 29, 2019

Simple enough.

before the PR while using bracketSpacing = true we would print:

import {symbol1 as alias, symbol2} from "File.sol";
import {symbol1 as alias1, symbol2 as alias2, symbol3 as alias3, symbol4} from "File2.sol";

after the PR:

import { symbol1 as alias, symbol2 } from "File.sol";
import {
    symbol1 as alias1,
    symbol2 as alias2,
    symbol3 as alias3,
    symbol4
} from "File2.sol";

It is a case that I didn't even know existed in import rules 😂

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #177 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files          74       74           
  Lines         554      554           
  Branches       84       84           
=======================================
  Hits          546      546           
  Misses          8        8
Impacted Files Coverage Δ
src/nodes/ImportDirective.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17bce0d...80531e0. Read the comment docs.

Copy link
Member

@mattiaerre mattiaerre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice thanks 👍

@Janther Janther force-pushed the feature/bracket_spacing_in_import_directive branch from 32ddf91 to 80531e0 Compare August 5, 2019 04:09
@mattiaerre mattiaerre merged commit e02f42e into master Aug 5, 2019
@mattiaerre mattiaerre deleted the feature/bracket_spacing_in_import_directive branch August 5, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants