Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for virtual keyword and abstract contracts #228

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

fvictorio
Copy link
Member

Part of #221.

Now abstract contract contracts are handled, and so are functions with the virtual keyword.

The override part is blocked by Consensys/solidity-parser-antlr#2

@codecov
Copy link

codecov bot commented Feb 16, 2020

Codecov Report

Merging #228 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
+ Coverage   99.01%   99.21%   +0.19%     
==========================================
  Files          74       78       +4     
  Lines         611      635      +24     
  Branches      101      103       +2     
==========================================
+ Hits          605      630      +25     
+ Misses          6        5       -1     
Impacted Files Coverage Δ
src/nodes/CatchClause.js 100.00% <0.00%> (ø)
src/nodes/DoWhileStatement.js 100.00% <0.00%> (ø)
src/nodes/TypeNameExpression.js 100.00% <0.00%> (ø)
src/nodes/AssemblyFunctionDefinition.js 100.00% <0.00%> (ø)
src/nodes/TryStatement.js 100.00% <0.00%> (ø)
src/nodes/ContinueStatement.js 100.00% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 618a1b6...9d180f1. Read the comment docs.

@mattiaerre mattiaerre merged commit 9b39d17 into master Feb 19, 2020
@mattiaerre mattiaerre deleted the abstract-and-virtual branch February 19, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants