Splitting and indenting variable declarations when necesary #230
Conversation
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
========================================
Coverage ? 99.2%
========================================
Files ? 78
Lines ? 632
Branches ? 102
========================================
Hits ? 627
Misses ? 5
Partials ? 0
Continue to review full report at Codecov.
|
| embrace ? concat(['(', doc, ')']) : doc; | ||
|
|
||
| const variables = (node, path, print) => | ||
| group( |
There was a problem hiding this comment.
I wonder if we can (and if we should) make a helper for this pattern, since we use it a lot. I guess something like this:
const printList = (node, path, print, key, separator = ',') =>
group(
concat([
indent(
concat([
softline,
join(
concat([separator, line]),
path.map(statementPath => print(statementPath), key)
)
])
),
softline
])
);
(with better names for the function and the parameters).
There was a problem hiding this comment.
This is a tricky one.
The pattern is used a lot but with small differences.
Sometimes times is a softline and sometimes is a line, the separator and the content also changes I’ll see how it looks having a function with many variables in one go vs a step by step declaration.
The system is already modular and there aren’t many files bigger than a screen.
I’ll give it a thought and play with the idea a little but probably for another PR.
There was a problem hiding this comment.
Sure. Just for the record: I'm fine with merging this as it is, I was just thinking out loud.
There was a problem hiding this comment.
Me too, I already got over my phase of having the driest possible code without really thinking of maintainability
Fixes #225
Before PR:
After PR:
( string memory holderId, string memory containerId, string memory parentContainerId, bytes32 volumeId, bytes32 subUnitId, bytes32 requestId ) = getParamsById(paramsId);