small detail on a do-while statement that breaks #231

Janther · 2020-02-18T03:07:47Z

Before PR:

do
    a = a.add(LONG_VARIABLE).add(LONG_VARIABLE).add(
        LONG_VARIABLE
    ); while (a < 200);

After PR:

do
    a = a.add(LONG_VARIABLE).add(LONG_VARIABLE).add(LONG_VARIABLE);
while (a < 200);

codecov · 2020-02-18T03:08:06Z

Codecov Report

❗ No coverage uploaded for pull request base (master@618a1b6). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master    #231   +/-   ##
========================================
  Coverage          ?   99.2%           
========================================
  Files             ?      78           
  Lines             ?     631           
  Branches          ?     102           
========================================
  Hits              ?     626           
  Misses            ?       5           
  Partials          ?       0

Impacted Files	Coverage Δ
src/nodes/DoWhileStatement.js	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 618a1b6...d9efb8d. Read the comment docs.

mattiaerre

good catch

mattiaerre · 2020-02-19T14:46:41Z

src/nodes/DoWhileStatement.js

 };

 const DoWhileStatement = {
  print: ({ node, path, print }) =>
    concat([
      'do',
      printBody(node, path, print),
-      ' while (',
+      'while (',


small detail on a do-while statement that breaks

d9efb8d

fvictorio approved these changes Feb 18, 2020

View reviewed changes

mattiaerre approved these changes Feb 19, 2020

View reviewed changes

mattiaerre merged commit 41aaf09 into master Feb 19, 2020

mattiaerre deleted the cleanup_do_while branch February 19, 2020 14:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

small detail on a do-while statement that breaks #231

small detail on a do-while statement that breaks #231

Janther commented Feb 18, 2020

codecov bot commented Feb 18, 2020 •

edited

Loading

mattiaerre left a comment

mattiaerre Feb 19, 2020

small detail on a do-while statement that breaks #231

small detail on a do-while statement that breaks #231

Conversation

Janther commented Feb 18, 2020

codecov bot commented Feb 18, 2020 • edited Loading

Codecov Report

mattiaerre left a comment

Choose a reason for hiding this comment

mattiaerre Feb 19, 2020

Choose a reason for hiding this comment

codecov bot commented Feb 18, 2020 •

edited

Loading