Print list

[Janther]

just playing with the idea of having a printList function (provided by @fvictorio) for most of our splitting and indenting cases.

The function just needs an array, but can also receive a firstSeparator (usually a softline used to separate from the previous character), a normal separator to put between items (usually a concat([',', line])), and finally the lastSeparator that in most cases is the same as firstSeparator with 2 exceptions (AssemblySwitch and StructDefinition).

const printList = (
  list,
  firstSeparator = softline,
  separator = concat([',', line]),
  lastSeparator = firstSeparator
) =>
  group(
    concat([
      indent(concat([firstSeparator, join(separator, list)])),
      lastSeparator
    ])
  );

Please have a look and see if it makes sense to use this pattern.

[codecov]

Codecov Report

Merging #234 into master will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   99.06%   99.21%   +0.14%     
==========================================
  Files          78       79       +1     
  Lines         639      633       -6     
  Branches      106      106              
==========================================
- Hits          633      628       -5     
+ Misses          6        5       -1     

Impacted Files	Coverage Δ
src/nodes/print-list.js	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 234790a...4cadc86. Read the comment docs.

[fvictorio]

I think I like this. Most usages use default arguments, so that's nice.

The only problem I see is that when explicit arguments are added, it gets a little cryptic. What do you think about having just an options parameter, so that the calls are more explicit (the "javascript doesn't have named parameters so this is the best we can do" pattern):

const printList = (
  list,
  {
    firstSeparator = softline,
    separator = concat([',', line]),
    lastSeparator = firstSeparator,
  } = {}
) =>

[Janther]

done, this idea was on the back of my mind. Glad that you proposed it aswell.

[mattiaerre]

this is really cool, let's merge and deploy a new version