Coverage #237
Coverage #237
Conversation
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 99.21% 99.68% +0.47%
==========================================
Files 79 79
Lines 633 628 -5
Branches 106 104 -2
==========================================
- Hits 628 626 -2
+ Misses 5 2 -3
Continue to review full report at Codecov.
|
| if (ctx.loopExpression) { | ||
| ctx.loopExpression.omitSemicolon = true; | ||
| } | ||
| ctx.loopExpression.omitSemicolon = true; |
There was a problem hiding this comment.
I guess that w/in ForStatements we always have a ctx.loopExpression right?
There was a problem hiding this comment.
Yeah, the initial expression and the condition expression can be null but for some reason the loop expression is an expression with null content.
Maybe we can ask for some consistency but right now that’s how it is
| @@ -6,15 +6,22 @@ const { | |||
|
|
|||
| const printList = require('./print-list'); | |||
|
|
|||
| const parameters = (node, path, print) => | |||
There was a problem hiding this comment.
just noticing this right now, do we always use function expressions?
There was a problem hiding this comment.
I tend to favour this notation. Is there an improvement by using declarations instead?
There was a problem hiding this comment.
not really, but to me, if it's a function I like to signal that w/ the function keyword
This PR solves an issue with try/catch discovered by adding more coverage cases and ups the coverage of
src/nodesto a 100%