favouring terciary operator over if...return...else...return #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
- Coverage 99.7% 99.68% -0.03%
==========================================
Files 84 84
Lines 677 633 -44
Branches 115 113 -2
==========================================
- Hits 675 631 -44
Misses 2 2
Continue to review full report at Codecov.
|
mattiaerre
approved these changes
Feb 28, 2020
fvictorio
approved these changes
Feb 28, 2020
|
Oh, that's a good point @fvictorio I don't wanna compromise readability. But in this case, I'm neutral. What should we be doing? |
|
I'm mostly neutral too, so I'm fine with merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really necessary. It just feels nicer and a bit cleaner.