Modifiers now will keep virtual and override #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also updated the parser before dependabot did, so I’m not sure what type
of conflicts will be there.
It’s up to you.
…On Fri, 5 Jun 2020 at 11:47, Mattia Richetto ***@***.***> wrote:
I think I can merge #286
<#286>
first @Janther <https://github.com/Janther> what do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#287 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHZQZUIBRFYMKDVILIU2A3RVAXBRANCNFSM4NSNRZMQ>
.
|
|
it looks like it did it before you did it and also I thought you were happy about that since you suggested to use dependabot. in this case, I'll close its PR and merge yours instead. |
|
Well yes but in my local machine I already had the changes
…On Fri, 5 Jun 2020 at 13:09, Mattia Richetto ***@***.***> wrote:
***@***.**** approved this pull request.
👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#287 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHZQZRA7NDGPB6P43C3OETRVBAVZANCNFSM4NSNRZMQ>
.
|
fvictorio
approved these changes
Jun 5, 2020
|
Thanks for doing this @Janther! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #279 and #277
bumping the dependency and also tweaking the variable declaration node.