Print returns in function types at the end #333
Conversation
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
@adjicf @andrekorol can you check if this looks good to you?
There was a problem hiding this comment.
I've cloned the function-types branch and successfully ran the Jest tests locally.
But when running prettier with the function-types branch installed on node_modules/prettier-plugin-solidity, I still get the same ParserError:
contracts/Pyramid.sol[error] contracts/Pyramid.sol: ParserError: extraneous input 'pure' expecting {',', ')'} (10:44)
I wonder if that's a problem with the Solidity parser (federicobond/solidity-parser-antlr) used by this plugin.
I noticed that the tests on AllSolidityFeatures.sol are using pragma solidity ^0.4.0;, but the contract I'm getting the ParserError on was using pragma solidity >=0.4.16 <0.8.0;, and the version of solc I was using to compile it is 0.7.0. I'm not sure, but another possibility is that this error only arises when using solc-0.7.x.
This is nothing critical or urgent though, the contract in question is from the Solidity documentation and can be found in this section: Function Types.
There was a problem hiding this comment.
I'll merge as is and maybe we can have a follow-up PR?
There was a problem hiding this comment.
That's fine by me :)
I would have to take a closer look at the problem before creating a new PR, but from quick experimentation, the problem only seems to come up when using solc-0.7.
There was a problem hiding this comment.
@andrekorol can you open an issue if that's still happening to you? And btw, if you think it's a bug with the parser (which it's likely), you can open an issue in https://github.com/solidity-parser/parser too
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
=======================================
Coverage 99.71% 99.71%
=======================================
Files 88 88
Lines 693 693
Branches 130 130
=======================================
Hits 691 691
Misses 2 2
Continue to review full report at Codecov.
|
fvictorio
force-pushed
the
function-types
branch
from
4eb8c62
to
e6fc3e0
Compare
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I'll merge as is and maybe we can have a follow-up PR?
Fixes #325
Fixes #330