space-after-if-condition

[mattiaerre]

Description

• add a line before ContractDefinition

• add space after the condition for IfStatement

• fix Add space before if's opening braces #37

• fix Put while opening brace in the same line #38

[codecov]

Codecov Report

Merging #39 into master will increase coverage by 12.55%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master      #39       +/-   ##
===========================================
+ Coverage   52.22%   64.77%   +12.55%     
===========================================
  Files           4        4               
  Lines         157      159        +2     
  Branches       34       35        +1     
===========================================
+ Hits           82      103       +21     
+ Misses         61       49       -12     
+ Partials       14        7        -7

Impacted Files	Coverage Δ
src/printer.js	61.37% <100%> (+13.82%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39cc037...127c362. Read the comment docs.

[mattiaerre]

it fails if you run AST_COMPARE=true npm run test; can you help us w/ this @j-f1 ?

    Difference:

    - Expected
    + Received

    @@ -155,15 +155,16 @@
                  ],
                  "type": "Block",
                },
                "isConstructor": true,
                "modifiers": Array [],
    -           "name": null,
    +           "name": "BasicIterator",
                "parameters": Object {
                  "parameters": Array [],
                  "type": "ParameterList",
                },
    +           "returnParameters": null,
                "stateMutability": null,
                "type": "FunctionDefinition",
                "visibility": "default",
              },
              Object {

      66 |           expect(ppastMassaged).toBeDefined();
      67 |           if (!astMassaged.errors || astMassaged.errors.length === 0) {
    > 68 |             expect(astMassaged).toEqual(ppastMassaged);
         |                                 ^
      69 |           }
      70 |         });
      71 |       }

      at Object.test (tests_config/run_spec.js:68:33)

[j-f1]

Those are the kinds of issues that the AST-massaging function can handle.

[mattiaerre]

not sure if I understand what you mean @j-f1 ; shall we change something here?

https://github.com/prettier-solidity/prettier-plugin-solidity/blob/master/tests_config/run_spec.js#L52-L71

[j-f1]

I think so.

[mattiaerre]

dah 😅 @j-f1 as we "translate" function ContractName => constructor

[fvictorio]

The plugin is doing that right now? I mean, converting function Contract to constructor? Because that shouldn't be prettier's responsibility IMO.

[mattiaerre]

100% agree. Apparently it does that. See if I can fix it.

[fvictorio]

I guess the parser adds the isConstructor metadata to functions named as the contract, and the printer function uses that to print constructor.

[federicobond]

LGTM

[mattiaerre]

merging this and opening a new PR to try to fix #32