using ... for ... supporting functions and global #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvictorio
reviewed
May 25, 2022
| 'using ', | ||
| node.libraryName, | ||
| node.functions && node.functions.length |
There was a problem hiding this comment.
I would remove the .length check:
Suggested change
| node.functions && node.functions.length | |
| node.functions |
Even if this is not technically allowed by the grammar, I think it's more future-proof to allow a potential result of using {} for .... The alternative is to use node.libraryName, which will be undefined and make the process fail.
There was a problem hiding this comment.
node.functions is always an Array even if it's an empty one :(
There was a problem hiding this comment.
Oh 🤦♂️ You are right, sorry.
Janther
force-pushed
the
feature/using_functions_for
branch
from
75db84b
to
8f504ee
Compare
fvictorio
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #674
Adding support for a list of functions for
UsingForDeclarationsAdding support for the word global