Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off @typescript-eslint/comma-dangle #159

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Turn off @typescript-eslint/comma-dangle #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions @typescript-eslint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ module.exports = {
"@typescript-eslint/quotes": 0,

"@typescript-eslint/brace-style": "off",
"@typescript-eslint/comma-dangle": "off",
"@typescript-eslint/comma-spacing": "off",
"@typescript-eslint/func-call-spacing": "off",
"@typescript-eslint/indent": "off",
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,7 +740,7 @@ eslint-config-prettier has been tested with:
- eslint-config-prettier 2.10.0 and older were tested with ESLint 4.x
- eslint-config-prettier 2.1.1 and older were tested with ESLint 3.x
- prettier 2.0.5
- @typescript-eslint/eslint-plugin 3.1.0
- @typescript-eslint/eslint-plugin 4.2.0
- eslint-plugin-babel 5.3.0
- eslint-plugin-flowtype 5.1.3
- eslint-plugin-react 7.20.0
Expand Down
203 changes: 174 additions & 29 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
"get-stdin": "^6.0.0"
},
"devDependencies": {
"@typescript-eslint/eslint-plugin": "3.1.0",
"@typescript-eslint/parser": "3.1.0",
"@typescript-eslint/eslint-plugin": "4.2.0",
"@typescript-eslint/parser": "4.2.0",
"babel-eslint": "10.1.0",
"cross-spawn": "7.0.3",
"doctoc": "1.4.0",
Expand Down
2 changes: 1 addition & 1 deletion test-lint/@typescript-eslint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable quotes */
/* eslint-disable quotes, no-unused-vars */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] Without no-unused-vars, linting fails:

$ npm --silent run test:lint

/Users/ybiquitous/eslint-config-prettier/test-lint/@typescript-eslint.ts
  6:11  error  'Foo' is defined but never used  no-unused-vars

✖ 1 problem (1 error, 0 warnings)

"use strict";

// Prettier wants 2-space indentation,
Expand Down