Fix: Support ESLint <3.11.0 #24
Conversation
eslint-plugin-prettier.js
Outdated
| }; | ||
| } | ||
| // Add 1 for the line ending character | ||
| offset = offset + lines[i].length + 1; |
There was a problem hiding this comment.
I think this will be incorrect if a file contains CRLF newlines, because the line ending will have a length of 2.
IIRC, there isn't enough information in the lines array to compute this accurately because it doesn't store which linebreaks were used. astUtils.getLocationFromRangeIndex was implemented by splitting the text into lines again and including linebreaks in the result.
There was a problem hiding this comment.
Ah so true - can you tell I don't interact with windows much? 😛 I circle back to this tmw.
eslint-plugin-prettier.js
Outdated
| const sourceCode = context.getSourceCode(); | ||
| if (typeof sourceCode.getLocFromIndex === 'function') { | ||
| return sourceCode.getLocFromIndex(index); | ||
| } | ||
| // Otherwise, try to use the private version from eslint/lib/ast-utils - | ||
| // added in ESLint 3.11.0. | ||
| const astUtils = require('eslint/lib/ast-utils'); |
There was a problem hiding this comment.
I haven't figured out the root cause yet, but I think using require('eslint') might be the source of #11 and #19. That could happen if the module found by running require('eslint') is not the same as the eslint module that is actually running the rule, which could result in neither sourceCode.getLocFromIndex nor astUtils.getLocationFromRangeIndex existing even when both modules are above 3.11.0.
That said, I guess this isn't a problem anymore because the fallback will get used now if neither function exists.
zertosh
force-pushed
the
eslint-getlocfromindex
branch
from
f71af59
to
4943e2d
Compare
|
@not-an-aardvark, I removed the use of |
Converting from a range/index to a location varies between ESLint versions. This PR covers versions all the way back to ESLint 3.9.0, and creates a test matrix of the various versions.
Context: Unfortunately, we have a project with ESLint 3.9.0 that I can't update right now without making a mess.