Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test #2

Merged
merged 6 commits into from
Sep 27, 2022
Merged

Fix test #2

merged 6 commits into from
Sep 27, 2022

Conversation

fisker
Copy link
Member

@fisker fisker commented Sep 27, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@e9a5b28). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main        #2   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         1           
  Lines           ?       314           
  Branches        ?         0           
========================================
  Hits            ?       314           
  Misses          ?         0           
  Partials        ?         0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fisker fisker marked this pull request as ready for review September 27, 2022 02:41
@fisker fisker mentioned this pull request Sep 27, 2022
Merged
4 tasks
sosukesuzuki
sosukesuzuki reviewed Sep 27, 2022
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. One comment.

.github/workflows/continuous-integration.yml
# - "macos-latest"
# - "windows-latest"
node_version:
- "18"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier v3 will support Node.js >= 14, so we should test parse-srcset on 14, 16, 18?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node:test module only available on 18

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, so I think we should use other lightweight testing library (e.g.https://github.com/lukeed/uvu) instead of node:test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's nessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I don't have strong opinion. Let's consider this when we actually something happend.

@fisker fisker merged commit 342b62e into main Sep 27, 2022
@fisker fisker deleted the test branch September 27, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

@thorn0 thorn0 Awaiting requested review from thorn0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fisker @codecov-commenter @sosukesuzuki