Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array setting #110

Closed
mathieutu opened this issue Feb 23, 2018 · 2 comments
Closed

array setting #110

mathieutu opened this issue Feb 23, 2018 · 2 comments

Comments

@mathieutu
Copy link

Before/after

-    protected $fillable = ['title', 'description', 'requester_id', 'type', 'summary', 'proof', 'budget_id'];
+    protected $fillable
+        = ['title', 'description', 'requester_id', 'type', 'summary', 'proof', 'budget_id'];

(actually I don't know if this kind of message really helps you, I'm just reporting all the bugs I'm seeing, but tell me if it's not relevant.)

@czosel
Copy link
Collaborator

czosel commented Feb 23, 2018

Hi @mathieutu, we definitely appreciate your feedback! Since we're bound to the 80 character limit, i guess your example should be formatted like this:

protected $fillable = [
  'title', 
  'description', 
  (...)
];

/cc @evilebottnawi @mgrip

@alexander-akait
Copy link
Member

@mathieutu yes, each item on new line better, no new option

czosel added a commit to czosel/plugin-php that referenced this issue Feb 25, 2018
czosel added a commit that referenced this issue Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants