fix: strings #136
Merged
fix: strings #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
fix-string-escaping
branch
2 times, most recently
from
2ce22c0
to
a6635e9
Compare
alexander-akait
force-pushed
the
fix-string-escaping
branch
from
a6635e9
to
000f426
Compare
mgrip
approved these changes
Mar 1, 2018
| // $string = 'You can also have embedded\\n newlines in | ||
| // strings this way as it is | ||
| // okay to do'; | ||
| $string = 'Arnold once said: "I\\'ll be back"'; |
There was a problem hiding this comment.
Same thing - i think an extra \ got added
There was a problem hiding this comment.
@mgrip yep let's add test, but here all fine with \, jest always escaped special characters
There was a problem hiding this comment.
just realized that - thanks! looks good to me!
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| <?php | ||
| $string = 'this is a simple string'; | ||
| // $string = 'You can also have embedded\\n newlines in |
There was a problem hiding this comment.
this should remain <- nvm realized this is how the snapshot gets printed'You can also have embedded\n newlines in, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All buggy things are commented.
Feel free to feedback.
Issue about syntax: #138.
Let's review this and merge as is. It is maximum how we can handle strings right now.