fix: update parser to fix precedence of ** and ?? #1440
Conversation
czosel
force-pushed
the
update-parser-precedence-right-associative
branch
from
75d2275
to
6981e09
Compare
|
Of course - done 🙃 |
There was a problem hiding this comment.
Meinen Segen hast du. 😁
But seriously, as I said I'm currently pretty restricted in spare time because of childcare, so if @evilebottnawi has reviewed something I usually don't bother to give it a third pair of eyes when there are just small changes. Would you like me to just ignore those review requests or approve them with an "I was here" note? 😉
|
@loilo Danke 😉 It's totally fine if you just ignore the reviews - until now I usually assigned both of you, but never waited with merging until i had both approvals. If you prefer i can also try to only ask you for reviews of PRs related to things you contributed (e.g. rollup-related stuff)? |
|
I don't mind the review request itself. When I have time to spare, I usually take a look. I'd say, if you've already got approval from @evilebottnawi, don't bother just merging the PR. 🙂 |
Upstream PR: glayzzle/php-parser#549
Fixes #1421