Improve doc print #1922
Merged
Improve doc print #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow nice, I didn't know about |
|
It is probably time to upgrade to more modern prettier and drop support for older nodejs versions. I tried this somewhat recently, and there is a lot to fix, this is a great first step. |
Merged
|
@alexander-akait done 🎉 |
cseufert
approved these changes
Mar 14, 2023
|
This looks great. |
|
It took us long enough to get this merged 🙈 thanks again @fisker! |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to help remove the deprecated
concatcommand, but I found we are still running tests withprettier@2.1.2, are we going to continue to support old version?Anyway,
eslint-plugin-prettier-docshould be useful whenever you decide to removeconcat().Changes in this PR are problems caught by other rules in
eslint-plugin-prettier-doc.