Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addes support for final class const #2186

Merged
merged 3 commits into from
Jun 11, 2023
Merged

Addes support for final class const #2186

merged 3 commits into from
Jun 11, 2023

Conversation

cseufert
Copy link
Collaborator

@cseufert cseufert commented Jun 5, 2023

Fixes #2183

Requires change to PHP Parser in https://github.com/glayzzle/php-parser/pull/1110/commits

@czosel czosel merged commit 29f3706 into main Jun 11, 2023
11 of 14 checks passed
@czosel
Copy link
Collaborator

czosel commented Jun 11, 2023

👍 LGTM

@czosel czosel deleted the cs-fix-class-final-const branch June 11, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Final class constants (aka. final public const) should stay final on PHP >= 8.1
2 participants