Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make format compatible with "PER Coding Style 2.0" #2269

Merged

Conversation

ferchoz
Copy link
Contributor

@ferchoz ferchoz commented Oct 19, 2023

This change allows to use this plugin along with "PER Coding Style 2.0"
formating :
readonly final class ClassName {}
to
final readonly class ClassName {}

doc:
https://www.php-fig.org/per/coding-style/#46-modifier-keywords

@ferchoz
Copy link
Contributor Author

ferchoz commented Oct 22, 2023

Hi @czosel can you take a look a this PR?
Thanks!

@PedroTroller
Copy link

PedroTroller commented Oct 27, 2023

I want to make this change, I look at the PRs and I realise that I'm 5 days late... Thanks @ferchoz ;)
You can probably rename your PR to specify that it's not just to make it compatible with php-cs-fixer but above all with the php-fig.org PER Coding Style 2.0.

@ferchoz ferchoz changed the title feat: make format compatible with php cs fixer feat: make format compatible with "PER Coding Style 2.0" Oct 27, 2023
Copy link
Collaborator

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ferchoz, thanks for contributing and sorry about the delay! The idea looks good to me, just a minor point for completeness.

src/printer.js Outdated Show resolved Hide resolved
@ferchoz
Copy link
Contributor Author

ferchoz commented Nov 28, 2023

Hi @ferchoz, thanks for contributing and sorry about the delay! The idea looks good to me, just a minor point for completeness.

Improved!

@ferchoz ferchoz requested a review from czosel November 28, 2023 16:17
@ferchoz
Copy link
Contributor Author

ferchoz commented Dec 5, 2023

@czosel can you take a look at it? thanks!!

@czosel czosel force-pushed the feature/make-format-compatible-with-phpcsfixer branch from b8128f5 to 9fe6fd5 Compare December 16, 2023 18:45
Copy link
Collaborator

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for contributing @ferchoz

@czosel czosel merged commit e3f8cba into prettier:main Dec 16, 2023
12 checks passed
@czosel
Copy link
Collaborator

czosel commented Dec 16, 2023

Released in v0.22.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants