Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing pass by reference for functions and methods #35

Merged
merged 3 commits into from
Feb 15, 2018
Merged

Fixing pass by reference for functions and methods #35

merged 3 commits into from
Feb 15, 2018

Conversation

mgrip
Copy link
Contributor

@mgrip mgrip commented Feb 14, 2018

Addressing #34

@mgrip mgrip requested a review from czosel February 14, 2018 22:23
@mgrip
Copy link
Contributor Author

mgrip commented Feb 14, 2018

Added in a fix for #36 because I didn't want to get merge conflicts. One note is that the parser currently doesn't handle all native types - once this is addressed we can update the test case

czosel
czosel approved these changes Feb 15, 2018
View reviewed changes
Copy link
Collaborator

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@czosel czosel merged commit 86272a4 into prettier:master Feb 15, 2018
This was referenced Feb 15, 2018
Closed
Closed
@mgrip mgrip deleted the pass-by-reference branch February 23, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czosel czosel czosel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mgrip @czosel