don't use tokens for build new ast for inline #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, good point about the branches - probably post-processing the AST is really not the way to move forward and this should be changed in the parser instead. |
czosel
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I studied in detail and came to the conclusion that this is the only working solution at the moment, not breaking the code.
Why?
Inline nodes can be in branch of control structures and it is very hard implement. (example inline node can be inside
else iforelse). Introduce new ast nodes (or andd based on tokens) is very bad solution (i vote doesn't do this never), many nodes can contain branches liketest,esle,testExpr,argumentsand etc, we will have to run through them - it is a lot of lines of code and a lot of bugs. Better wait fix in parses (or fix it and send PR).