Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't add extra newline in last inline node #555

Merged
merged 1 commit into from Aug 31, 2018

Conversation

alexander-akait
Copy link
Member

this bug also exists in #550

@alexander-akait
Copy link
Member Author

Looks all code in markdown now interpreted as inline 😕 It is big bug

Copy link
Collaborator

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, i think i noticed this as well in #418

@@ -158,7 +158,6 @@ if (true) {
}
echo 'bar';
?>
test
\`\`\`
test\`\`\`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug in prettier prettier/prettier#5037

@alexander-akait
Copy link
Member Author

Merge as is, we can't fix prettier bug here, feel free to feedback

@alexander-akait alexander-akait merged commit 7d2610e into master Aug 31, 2018
@alexander-akait alexander-akait deleted the fix-extra-newline-in-last-inline branch August 31, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants