Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: [coc.nvim] pug not supported by prettier #150

Closed
ryeballar opened this issue Oct 29, 2020 · 1 comment · Fixed by #151
Closed

Bug: [coc.nvim] pug not supported by prettier #150

ryeballar opened this issue Oct 29, 2020 · 1 comment · Fixed by #151
Assignees
@ryeballar
Labels
type: enhancement Functionality that enhances existing features

Comments

@ryeballar
Copy link
Contributor

ryeballar commented Oct 29, 2020 •
edited

Info

Tool Version
Plugin v1.10.0
Prettier v2.1.2
Node v12.19.0
OS linux

The Issue

coc-prettier is a fork of prettier-vscode where its implementation heavily relies on the the file type defined in vim and the vscodeLanguageIds defined in the plugin being supported.

I'm currently using vim-pug for syntax highlighting which maps any file or buffer with the extension .pug or .jade to the pug editor file type. coc-prettier will compare that pug file type against all vscodeLanguageIds gathered across different prettier plugins which will unfortunately fail since plugin-prettier defines vscodeLanguageIds with [ "jade" ].

Resolution:

Add pug in the vscodeLanguageIds array.
@ryeballar ryeballar mentioned this issue Oct 29, 2020
Merged
@Shinigami92 Shinigami92 added the type: enhancement Functionality that enhances existing features label Oct 31, 2020
@Shinigami92
Copy link
Member

Shinigami92 commented Nov 1, 2020 •
edited

This has now been released 1.10.1
Please let me know if it works the way you want it
Thank you for using my plugin and for being part of the pug community 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryeballar ryeballar

Labels
type: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pug to vscodeLanguageIds
2 participants
@ryeballar @Shinigami92