Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute interpolation using quotes #179

Merged
merged 3 commits into from
Feb 18, 2021
Merged

Conversation

Cloudless67
Copy link
Contributor

This is fix for issue #58.

@Shinigami92 Shinigami92 added the type: bug Functionality that does not work as intended/expected label Feb 18, 2021
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work 🎉
Really much ❤️ to you for fixing this really old issue 😃
I think you will make many devs in our community happy with that!

One more thing you can do is removing all the parts that addressing this workaround like in the README.md

I will update the changelog on my own and managing the next version number, so you don't need to check for these.

src/utils/common.ts Outdated Show resolved Hide resolved
tests/issues/issue-58/issue-58.test.ts Outdated Show resolved Hide resolved
@Shinigami92
Copy link
Member

Oh, and one more thing that would be cool: Could you write inline comments or improve the JSDoc for the function to address this improved special behavior?
It's not really clear what the regex pattern is doing and why it is doing so. 😄

@Cloudless67
Copy link
Contributor Author

First, thanks for quick review:)

I'll try to work on things you've said!

@Shinigami92
Copy link
Member

@Cloudless67 I'm currently in some meetings and think I can create a release todays evening

A little minor change you could make is correcting the capital typo in the comment

Regex for Checking if there are any unescaped quotations.
Regex for checking if there are any unescaped quotations.

@Shinigami92 Shinigami92 merged commit c926849 into prettier:main Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Attribute Interpolation not using template literals and using quotes
3 participants