This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
feat(options): add prettierLast option for prettier-eslint #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwise
suggested changes
Mar 31, 2017
src/executePrettier.test.js
Outdated
| helpers.shouldUseEslint.mockImplementation(() => true); | ||
| // $FlowFixMe | ||
| helpers.getCurrentFilePath.mockImplementation(() => 'foo.js'); | ||
| helpers.getPrettierEslintOptions.mockImplementation(() => ({ prettierLast: true })); |
There was a problem hiding this comment.
we just need to add a // $FlowFixMe here to pass flow
done. |
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=========================================
+ Coverage 78.57% 78.98% +0.4%
=========================================
Files 6 6
Lines 154 157 +3
=========================================
+ Hits 121 124 +3
Misses 33 33
Continue to review full report at Codecov.
|
robwise
approved these changes
Mar 31, 2017
|
@spudly awesome, can you squash down that commit? |
|
squashed. also added myself as contributor the right way, as I had done it manully before. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
Run Prettier Lastoption (see prettier/prettier-eslint#58 and prettier/prettier-eslint#59).