Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Prettier to version 2 #177

Merged
merged 12 commits into from
Mar 27, 2020
Merged

Upgrade Prettier to version 2 #177

merged 12 commits into from
Mar 27, 2020

Conversation

nickmccurdy
Copy link
Member

@nickmccurdy nickmccurdy commented Mar 23, 2020 •
edited

  • Keeps extension's formatting defaults consistent with Prettier's breaking changes
  • Simplifies our own scripts and updates our formatting
  • Renames parsers

@nickmccurdy nickmccurdy marked this pull request as ready for review March 23, 2020 08:16
@kaicataldo
Copy link
Member

Hmmm looks like Travis is broken?

@nickmccurdy
Copy link
Member Author

It seems like this repository is still using the legacy GitHub services integration for Travis, which has not been supported as of January 31st. I've sent a request to the organization admins to add this repository to the GitHub app integration. I believe once that's accepted, we can migrate the existing configuration over and it should start processing builds again.

@nickmccurdy

This comment has been minimized.

Sign in to view
@nickmccurdy
Copy link
Member Author

Still seems to be broken even though Travis says the issue is fixed, migration is worth trying.

@lipis
Copy link
Member

lipis commented Mar 27, 2020

We should switch to GitHub actions

@nickmccurdy
Copy link
Member Author

Upgraded Prettier to 2.0.2 and fixed the GitHub Actions build

@kaicataldo kaicataldo merged commit 7cbbc20 into master Mar 27, 2020
@kaicataldo kaicataldo deleted the upgrade-prettier branch March 27, 2020 20:10
@nickmccurdy nickmccurdy mentioned this pull request Mar 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickmccurdy @kaicataldo @lipis