Maintain Browser history on 'Prettier' + Fix issue with button on appearing on 'Create pull Request' #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipis
approved these changes
Oct 13, 2019
|
For future reference if you add |
|
Ah will do so in future, Thanks! I'm relatively new to open source so apologies for not knowing these things |
|
No worries @Wicked7000 :) We've all been there.. welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address the issue raised in:
#22
This was fixed by switching to document.execCommand to insert the text into the textarea, which allows the browser to continue to keep track of history -> We should probably use this as the standard way of modifying text rather than setting the value.
Along with a small bugfix to check for the existence of the 'js-discussion' element before trying to observe it. (This was causing the 'Prettier' button to not render on the Create pull request pages)
Let me know if you have any questions or concerns.