Add Option to format via context menu

[sibiraj-s]

Closes #20, Partially adresses #21

[kaicataldo]

Related discussion: #322

[nickmccurdy]

Thanks for this. I think contex-menu.js should be context-menu.js. Also have you been able to confirm that this works in our supported sites on Firefox, and the existing non-menu functionality still works in Chrome?

[sibiraj-s]

I think contex-menu.js should be context-menu.js

AutoComplete 😅 . updated now.

Also have you been able to confirm that this works in our supported sites on Firefox, and the existing non-menu functionality still works in Chrome?

Yes. I verified it. There is no changes to existing code and the context-menu script is loaded only in Firefox.

[kaicataldo]

Thanks for the PR! I'd like to implement #322 before we add any other functionality to the extension. I'm definitely not against considering this in the future once that's completed, but I think it's best to start with the new approach and see what we feel is missing.

[kaicataldo]

#322 has been merged. We should re-evaluate this in light of the new behavior.

[sibiraj-s]

Thanks @kaicataldo .

RightClick to format is a general option available mostly everywhere. I think it would be nice to include the feature. May be with the current changes. I may be even make it work across the browsers.

[kaicataldo]

I definitely think it's a good idea!

I wonder if we can add two context menu options:

• "Format with Prettier"
• "Format with Prettier as ..."
  • JavaScript
  • Markdown
  • CSS
  • etc.

Thoughts?

[sibiraj-s]

Yes It is a nice option. Till we figure out language detection. It will be very handy.

I do remember giving a thought on this when I was working with this feature. I think there is a limitation. An Extension can have only one context menu option. Adding more than one will automatically group them into sub menus.

My memory is little vague on that. I will check and update back

[sibiraj-s]

Yes. It is not possible to render more than one context menu item

You can create as many context menu items as you need, but if more than one from your extension is visible at once, Google Chrome automatically collapses them into a single parent menu.

https://developer.chrome.com/docs/extensions/reference/contextMenus/#usage