Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing content #86

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Testing content #86

wants to merge 20 commits into from

Conversation

nickmccurdy
Copy link
Member

@nickmccurdy nickmccurdy commented Nov 7, 2019

#53

  • Test basic button injection
  • Create fully-functioning stubs
    • chrome.extension.storage.sync
    • MutationObserver
  • Attempt to test with mocked window.location
  • Test option loading behavior
  • Consider adding more granular unit tests per class/file/method/function
  • Consider using dom-testing-library for better assertions and consistency with Testing options #87
  • Complete test coverage

.eslintrc.json Outdated Show resolved Hide resolved
@kaicataldo
Copy link
Member

Can we fix the merge conflicts and merge this? If everything is set up, I don't think we need to wait until we have complete coverage before merging.

@kaicataldo

This comment has been minimized.

@nickmccurdy nickmccurdy marked this pull request as ready for review August 29, 2020 23:09
@nickmccurdy
Copy link
Member Author

nickmccurdy commented Aug 30, 2020

I'm going to see if I can swap in sinon-chrome similarly to #87 before I merge this. Maintaining mocks manually is a lot of churn.

Base automatically changed from master to main February 1, 2021 03:57
@kaicataldo
Copy link
Member

Are you still working on this? If not, I think it would be best to close the PR for now so others can feel free to work on it (would love to land this PR if you're still working on it, though!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants