Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for non-js files #10

Merged
merged 1 commit into from Jul 13, 2017

Conversation

aaronjensen
Copy link
Contributor

--stdin-filepath is necessary for parser inference to work. This fixes
Typescript/json/css/etc support.

`--stdin-filepath` is necessary for parser inference to work. This fixes
Typescript/json/css/etc support.
@rcoedo rcoedo merged commit 9cac36f into prettier:master Jul 13, 2017
@rcoedo
Copy link

rcoedo commented Jul 13, 2017

Thank you!

@aaronjensen aaronjensen deleted the fix-support-for-non-js branch July 13, 2017 10:11
@eqyiel
Copy link
Contributor

eqyiel commented Aug 28, 2017

This breaks compatibility with prettier-eslint-cli because that command doesn't have this option.

I think that's more of a problem of prettier-eslint-cli not presenting the same API though. 😿

@aaronjensen
Copy link
Contributor Author

I'd agree, though perhaps prettier-emacs could take an option for it.

That said, pardon my ignorance, but are there many things that prettier-eslint-cli is still necessary for now that prettier has the no-semi option? I've been able to use https://github.com/prettier/eslint-plugin-prettier for everything since then and https://github.com/aaronjensen/eslintd-fix with https://github.com/mantoni/eslint_d.js in emacs for projects using that.

@eqyiel
Copy link
Contributor

eqyiel commented Aug 28, 2017

@aaronjensen thanks for the tip, we'll give that a try!

BenoitZugmeyer added a commit to BenoitZugmeyer/prettier-eslint-cli that referenced this pull request Sep 27, 2017
This option is really usefull when using prettier-eslint-cli inside text
editor plugins, to let prettier-eslint discover the correct eslintrc
configuration for the given file.

Related:
* prettier#95
* sbdchd/neoformat#112
* prettier/prettier-emacs#10 (comment)
BenoitZugmeyer added a commit to BenoitZugmeyer/prettier-eslint-cli that referenced this pull request Sep 27, 2017
This option is really usefull when using prettier-eslint-cli inside text
editor plugins, to let prettier-eslint discover the correct eslintrc
configuration for the given file.

Related:
* prettier#95
* sbdchd/neoformat#112
* prettier/prettier-emacs#10 (comment)
BenoitZugmeyer added a commit to BenoitZugmeyer/prettier-eslint-cli that referenced this pull request Sep 27, 2017
This option is really usefull when using prettier-eslint-cli inside text
editor plugins, to let prettier-eslint discover the correct eslintrc
configuration for the given file.

Related:
* prettier#95
* sbdchd/neoformat#112
* prettier/prettier-emacs#10 (comment)
kentcdodds pushed a commit to prettier/prettier-eslint-cli that referenced this pull request Sep 27, 2017
This option is really usefull when using prettier-eslint-cli inside text
editor plugins, to let prettier-eslint discover the correct eslintrc
configuration for the given file.

Related:
* #95
* sbdchd/neoformat#112
* prettier/prettier-emacs#10 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants