Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for typescript files #121

Merged
merged 1 commit into from
Aug 31, 2017
Merged

Add basic support for typescript files #121

merged 1 commit into from
Aug 31, 2017

Conversation

zimme
Copy link
Member

@zimme zimme commented Aug 31, 2017

This should allow .ts/.tsx files to be run through prettier and eslint with proper parser settings.

@codecov-io
Copy link

codecov-io commented Aug 31, 2017

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #121   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         187    191    +4     
  Branches       31     32    +1     
=====================================
+ Hits          187    191    +4
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09eb76f...369fc27. Read the comment docs.

@zimme
Copy link
Member Author

zimme commented Aug 31, 2017

I don't know if better tests are needed. I've had a hard time validating that the typescript file is actually ran through eslint and fixed in any way.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@kentcdodds kentcdodds merged commit dbeda53 into prettier:master Aug 31, 2017
@kentcdodds
Copy link
Member

Thanks so much for all your help! I've added you as a collaborator on the project. Please make sure that you review the CONTRIBUTING.md file (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@zimme zimme mentioned this pull request Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants