Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESLint 7 (fixes #401) #407

Merged
merged 2 commits into from
Nov 21, 2020

Conversation

cy6erskunk
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2020

Codecov Report

Merging #407 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #407   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          208       208           
  Branches        42        42           
=========================================
  Hits           208       208           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71b504c...0f1d343. Read the comment docs.

@chrisbobbe
Copy link
Contributor

I think it's also necessary to grab a version of eslint-config-kentcdodds that works with ESLint 7, as I mentioned at #401 (comment), right?

It looks like such a version was released very recently (after I posted there): v16 (with a bugfix in v16.0.1)! 🎉

@cy6erskunk
Copy link
Contributor Author

Right, totally makes sense! Thanks for noticing it, @chrisbobbe

@abstracthat
Copy link

Is this good to merge? Would love to get prettier-eslint working with eslint 7.

@abstracthat
Copy link

Not sure who to ping, so taking a stab at @fisker @sosukesuzuki can this be merged?

@sosukesuzuki
Copy link
Member

Sorry, I'm not a maintainer of prettier-eslint and I'm not very familiar with it...

@fisker
Copy link
Member

fisker commented Nov 20, 2020

Me neither

@abstracthat
Copy link

Sorry about that guys... I accidentally looked at the main prettier commits log.

@hamzahamidi maybe? Can this be merged?

@hamzahamidi hamzahamidi merged commit 8f35b25 into prettier:master Nov 21, 2020
@zimme
Copy link
Member

zimme commented Nov 21, 2020

🎉 This PR is included in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants