Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resolveConfig to work with Prettier 3 #942

Merged
merged 5 commits into from Oct 27, 2023

Conversation

jkrehm
Copy link
Contributor

@jkrehm jkrehm commented Oct 27, 2023

The sync function is gone and only async version exists.

Also remove eslintPath argument that test function does not consume.

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

🦋 Changeset detected

Latest commit: 7f93b14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
prettier-eslint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

The `sync` function is gone and only async version exists.
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a896fc) 100.00% compared to head (7f93b14) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #942   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          295       291    -4     
  Branches        85        82    -3     
=========================================
- Hits           295       291    -4     
Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
@JounQin JounQin merged commit 103cc51 into prettier:master Oct 27, 2023
6 checks passed
@JounQin
Copy link
Member

JounQin commented Oct 27, 2023

@jkrehm Thanks for your contribution! This PR has been released at v16.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants