Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not register prettier plugin installed by pnpm #2586

Closed
tjx666 opened this issue Jun 14, 2022 · 7 comments
Closed

not register prettier plugin installed by pnpm #2586

tjx666 opened this issue Jun 14, 2022 · 7 comments
Labels
locked Please open a new issue and fill out the template instead of commenting.

Comments

@tjx666
Copy link

tjx666 commented Jun 14, 2022

image

Repoduce steps:

  1. git clone git@github.com:tjx666/adobe-devtools.git
  2. git reset --hard 77a25eadb2bfee5f3398437edd1b9d1248a82c03
  3. install dependencies by pnpm install
  4. try format xml file CSXS/manifest.xml
  5. try install dependencies by npm, no this issue
  • MacOS: 12.4
  • VSCode: 1.69.0-insider
  • extension: v9.5.0
  • Pnpm: 7.2.1
@ibrahimduran
Copy link

Temporary workaround that worked for me is using .prettierrc.js and manually resolving plugin imports as showed in here.

@JounQin
Copy link
Member

JounQin commented Jul 1, 2022

Duplicate of prettier/prettier#8474

@viceice
Copy link

viceice commented Jul 20, 2022

Same for yarn pnp. from cli i can format xml files when manual configure the plugins in .prettierrc.json or .prettierrc.cjs
But prettier-vscode isn't registering the xml formatter 😕

@viceice
Copy link

viceice commented Jul 20, 2022

ok, it seems prettier.getSupportInfo() doesn't take the config file into account, so prettier-vscode doesn't know about the plugin provided languages 😕

const { languages } = prettierInstance.getSupportInfo();

@ntotten
Copy link
Member

ntotten commented Aug 20, 2022

This is an issue or feature request for the Prettier library itself rather than the VS Code extension for prettier. Please open an issue at https://github.com/prettier/prettier.

@ntotten ntotten closed this as completed Aug 20, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked Please open a new issue and fill out the template instead of commenting. label Nov 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

5 participants