Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tslintIntegration: semicolon does not work #558

Closed
sveyret opened this issue Aug 18, 2018 · 2 comments
Closed

tslintIntegration: semicolon does not work #558

sveyret opened this issue Aug 18, 2018 · 2 comments
Labels
locked Please open a new issue and fill out the template instead of commenting.

Comments

@sveyret
Copy link

sveyret commented Aug 18, 2018

When setting tslintIntegration to true, prettier does not take into account its semi rule anymore, neither it takes the semicolon rule from tslint, at least in interface definition.

For example, in my interface definition:

export interface ApiDefinition extends RoutesType {
  lang: {
    url: { langCode: string }
    data: undefined
    header: undefined
    return: void
  }
  securityToken: {
    url: undefined
    data: undefined
    header: undefined
    return: string
  }
}

code formatting adds semicolons at almost each line:

export interface ApiDefinition extends RoutesType {
  lang: {
    url: { langCode: string };
    data: undefined;
    header: undefined;
    return: void;
  }
  securityToken: {
    url: undefined;
    data: undefined;
    header: undefined;
    return: string;
  }
}

Here is my configuration:

VS config (extract):

    "prettier.tslintIntegration": true,

tslint.yaml (extract):

extends:
  - >-
    common/tslint

common/tslint.yaml (extract):

  semicolon:
    options:
      - never
@sveyret
Copy link
Author

sveyret commented Aug 19, 2018

Moved to azz/prettier-tslint#16

@sveyret sveyret closed this as completed Aug 19, 2018
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked Please open a new issue and fill out the template instead of commenting. label Apr 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

1 participant