Enable import/no-anonymous-default-export (#11478)

* Enable import/no-anonymous-default-export

* Add names to default exported

* More

* Ignore shims

* Update scripts/build/config.mjs

Co-authored-by: fisker Cheung <lionkay@gmail.com>

* lint  for shims

Co-authored-by: fisker Cheung <lionkay@gmail.com>

.eslintrc.js

@@ -97,6 +97,7 @@ module.exports = {
       },
     ],
     "import/order": "error",
+    "import/no-anonymous-default-export": "error",
 
     "regexp/match-any": [
       "error",

scripts/build/config.mjs

@@ -162,4 +162,5 @@ const coreBundles = [
   ...bundle,
 }));
 
-export default [...coreBundles, ...parsers];
+const configs = [...coreBundles, ...parsers];
+export default configs;

scripts/build/rollup-plugins/evaluate.mjs

@@ -2,7 +2,7 @@ import createEsmUtils from "esm-utils";
 
 const { require } = createEsmUtils(import.meta);
 
-export default function () {
+export default function rollupPluginEvaluate() {
   return {
     name: "evaluate",
 

scripts/build/rollup-plugins/executable.mjs

@@ -1,7 +1,7 @@
 import fs from "node:fs";
 import path from "node:path";
 
-export default function () {
+export default function rollupPluginExecutable() {
   let banner;
   let entry;
   let file;

scripts/build/rollup-plugins/replace-module.mjs

@@ -1,4 +1,4 @@
-export default function (replacements = {}) {
+export default function rollupPluginReplaceModule(replacements = {}) {
   return {
     name: "replace-module",
 

scripts/build/shims/fs.mjs

@@ -1,3 +1,4 @@
 export const existsSync = () => false;
 export const readFileSync = () => "";
-export default { existsSync, readFileSync };
+const fs = { existsSync, readFileSync };
+export default fs;

scripts/build/shims/os.mjs

@@ -1,5 +1,6 @@
-export default {
+const os = {
   EOL: "\n",
   platform: () => "browser",
   cpus: () => [{ model: "Prettier" }],
 };
+export default os;

scripts/build/shims/tty.mjs

@@ -1,5 +1,6 @@
-export default {
+const tty = {
   isatty() {
     return false;
   },
 };
+export default tty;

scripts/release/steps/bump-prettier.js

@@ -36,7 +36,7 @@ async function bump({
   await writeJson("package.json", pkg, { spaces: 2 });
 }
 
-export default async function (params) {
+export default async function bumpPrettier(params) {
   const { dry, version } = params;
 
   if (dry) {

scripts/release/steps/check-git-status.js

@@ -1,6 +1,6 @@
 import { runGit } from "../utils.js";
 
-export default async function () {
+export default async function checkGitStatus() {
   const { stdout: status } = await runGit(["status", "--porcelain"]);
 
   if (status) {

scripts/release/steps/generate-bundles.js

@@ -1,7 +1,7 @@
 import chalk from "chalk";
 import { runYarn, logPromise, readJson } from "../utils.js";
 
-export default async function ({ version }) {
+export default async function generateBundles({ version }) {
   await logPromise("Generating bundles", runYarn(["build", "--purge-cache"]));
 
   const builtPkg = await readJson("dist/package.json");

scripts/release/steps/install-dependencies.js

@@ -13,6 +13,6 @@ async function install() {
   }
 }
 
-export default function () {
+export default function installDependencies() {
   return logPromise("Installing NPM dependencies", install());
 }

scripts/release/steps/post-publish-steps.js

@@ -43,7 +43,7 @@ function twitterAnnouncement() {
   `);
 }
 
-export default async function () {
+export default async function postPublishSteps() {
   const steps = [await checkSchema(), twitterAnnouncement()].filter(Boolean);
 
   console.log(chalk.bold.green("The script has finished!\n"));

scripts/release/steps/publish-to-npm.js

@@ -27,7 +27,7 @@ async function retryNpmPublish() {
   }
 }
 
-export default async function ({ dry, version }) {
+export default async function publishToNpm({ dry, version }) {
   if (dry) {
     return;
   }

scripts/release/steps/push-to-git.js

@@ -7,7 +7,7 @@ async function pushGit({ version }) {
   await runGit(["push", "--tags"]);
 }
 
-export default function (params) {
+export default function pushToGit(params) {
   if (params.dry) {
     return;
   }

scripts/release/steps/run-tests.js

@@ -1,6 +1,6 @@
 import { runYarn, logPromise } from "../utils.js";
 
-export default async function () {
+export default async function runTests() {
   await logPromise("Running linter", runYarn("lint:eslint"));
   await logPromise("Running Prettier on docs", runYarn("lint:prettier"));
   await logPromise("Running tests", runYarn("test"));

scripts/release/steps/update-changelog.js

@@ -42,7 +42,7 @@ async function getChangelogForPatch({ version, previousVersion }) {
   return changelog;
 }
 
-export default async function ({ version, previousVersion }) {
+export default async function updateChangelog({ version, previousVersion }) {
   const semverDiff = semver.diff(version, previousVersion);
 
   if (semverDiff !== "patch") {

scripts/release/steps/update-dependents-count.js

@@ -71,7 +71,7 @@ function formatNumber(value) {
   return Math.floor(value / 1e5) / 10 + " million";
 }
 
-export default async function () {
+export default async function updateDependentsCount() {
   try {
     await update();
   } catch (error) {

scripts/release/steps/update-version.js

@@ -32,6 +32,6 @@ async function bump({ version }) {
   });
 }
 
-export default async function (params) {
+export default async function updateVersion(params) {
   await logPromise("Bumping version", bump(params));
 }

scripts/release/steps/validate-new-version.js

@@ -1,7 +1,7 @@
 import chalk from "chalk";
 import semver from "semver";
 
-export default function ({ version, previousVersion }) {
+export default function validateNewVersion({ version, previousVersion }) {
   if (!semver.valid(version)) {
     throw new Error("Invalid version specified");
   }

website/playground/BottomBar.js

@@ -3,7 +3,7 @@ import * as ReactDOM from "react-dom";
 
 const root = document.getElementById("bottom-bar");
 
-export default function ({ left, right }) {
+export default function BottomBar({ left, right }) {
   return ReactDOM.createPortal(
     <React.Fragment>
       <div className="bottom-bar-buttons">{left}</div>

website/playground/EditorState.js

@@ -3,7 +3,7 @@ import * as React from "react";
 import { stateToggler, shallowEqual } from "./helpers.js";
 import * as storage from "./storage.js";
 
-export default class extends React.Component {
+export default class EditorState extends React.Component {
   constructor() {
     super();
     this.state = {

website/playground/VersionLink.js

@@ -3,7 +3,7 @@ import * as ReactDOM from "react-dom";
 
 const root = document.getElementById("version");
 
-export default function ({ version }) {
+export default function VersionLink({ version }) {
   const match = version.match(/^pr-(\d+)$/);
   let href;
   if (match) {

website/playground/WorkerApi.js

@@ -1,4 +1,4 @@
-export default function (source) {
+export default function WorkerApi(source) {
   const worker = new Worker(source);
   let counter = 0;
   const handlers = {};

website/playground/codeSamples.js

@@ -1,4 +1,4 @@
-export default function (parser) {
+export default function getCodeSamples(parser) {
   switch (parser) {
     case "babel":
     case "espree":

website/playground/sidebar/SidebarOptions.js

@@ -4,7 +4,7 @@ import groupBy from "lodash/groupBy";
 import { SidebarCategory } from "./components.js";
 import Option from "./options.js";
 
-export default function ({
+export default function SidebarOptions({
   categories,
   availableOptions,
   optionValues,

website/playground/sidebar/options.js

@@ -42,7 +42,7 @@ export function NumberOption({ option, value, onChange }) {
   );
 }
 
-export default function (props) {
+export default function Option(props) {
   switch (props.option.type) {
     case "boolean":
       return <BooleanOption {...props} />;