Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow generic has weird break #1301

Closed
SimenB opened this issue Apr 16, 2017 · 1 comment · Fixed by #1305
Closed

Flow generic has weird break #1301

SimenB opened this issue Apr 16, 2017 · 1 comment · Fixed by #1305
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:bug Issues identifying ugly output, or a defect in the program

Comments

@SimenB
Copy link
Contributor

SimenB commented Apr 16, 2017

https://prettier.github.io/prettier/#%7B%22content%22%3A%22export%20default%20class%20AddAssetHtmlPlugin%20%7B%5Cn%20%20apply(compiler%3A%20WebpackCompilerType)%20%7B%5Cn%20%20%20%20compiler.plugin('compilation'%2C%20(compilation%3A%20WebpackCompilationType)%20%3D%3E%20%7B%5Cn%20%20%20%20%20%20compilation.plugin('html-webpack-plugin-before-html-generation'%2C%20(htmlPluginData%3A%20Object%2C%20callback%3A%20Callback%3Cany%3E)%20%3D%3E%20%7B%5Cn%20%20%20%20%20%20%20%20addAllAssetsToCompilation(this.assets%2C%20compilation%2C%20htmlPluginData%2C%20callback)%3B%5Cn%20%20%20%20%20%20%7D)%3B%5Cn%20%20%20%20%7D)%3B%5Cn%20%20%7D%5Cn%7D%5Cn%22%2C%22options%22%3A%7B%22printWidth%22%3A120%2C%22tabWidth%22%3A2%2C%22singleQuote%22%3Atrue%2C%22trailingComma%22%3A%22es5%22%2C%22bracketSpacing%22%3Atrue%2C%22jsxBracketSameLine%22%3Afalse%2C%22parser%22%3A%22babylon%22%2C%22semi%22%3Atrue%2C%22useTabs%22%3Afalse%2C%22doc%22%3Afalse%7D%7D

I'd expect it to move the whole callback to a new line, not break on the generic:

(bah: Func<
any
>) =>
@vjeux vjeux added the type:bug Issues identifying ugly output, or a defect in the program label Apr 16, 2017
vjeux added a commit to vjeux/prettier that referenced this issue Apr 16, 2017
@vjeux
Avoid breaking arguments for last arg expansion
e2bf93e 
We've had this issue since the beginning and I tagged it as 1.0 but haven't managed to fix it by then. We shouldn't allow things to break in the argument list if we are in the last argument expansion mode. It turns out that we now have all the building blocks needed to fix this:
- have a special way to flag when we are printing the last argument expansion in the code that prints the argument list
- have a way to remove all the softlines from the argument list

Fixes prettier#1301
@vjeux vjeux mentioned this issue Apr 16, 2017
Merged
@vjeux
Copy link
Contributor

vjeux commented Apr 16, 2017

Thanks! It's been an issue since the early days and we now have the proper infrastructure to fix it :) #1305

vjeux added a commit that referenced this issue Apr 18, 2017
@vjeux
Avoid breaking arguments for last arg expansion (#1305)
8d03423 
We've had this issue since the beginning and I tagged it as 1.0 but haven't managed to fix it by then. We shouldn't allow things to break in the argument list if we are in the last argument expansion mode. It turns out that we now have all the building blocks needed to fix this:
- have a special way to flag when we are printing the last argument expansion in the code that prints the argument list
- have a way to remove all the softlines from the argument list

Fixes #1301
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid breaking arguments for last arg expansion vjeux/prettier
2 participants
@vjeux @SimenB