Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing parenthesis in single argument arrow function with comment in flow parser #1335

Closed
vjeux opened this issue Apr 18, 2017 · 0 comments
Closed

Missing parenthesis in single argument arrow function with comment in flow parser #1335

vjeux opened this issue Apr 18, 2017 · 0 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:bug Issues identifying ugly output, or a defect in the program

Comments

@vjeux
Copy link
Contributor

vjeux commented Apr 18, 2017

Babylon is fine.

call((/*object*/ row) => {});

outputs

call(/*object*/ row => {});

https://prettier.github.io/prettier/#%7B%22content%22%3A%22call((%2F*object*%2F%20row)%20%3D%3E%20%7B%7D)%3B%5Cn%22%2C%22options%22%3A%7B%22printWidth%22%3A80%2C%22tabWidth%22%3A2%2C%22singleQuote%22%3Afalse%2C%22trailingComma%22%3A%22all%22%2C%22bracketSpacing%22%3Atrue%2C%22jsxBracketSameLine%22%3Afalse%2C%22parser%22%3A%22flow%22%2C%22semi%22%3Atrue%2C%22useTabs%22%3Afalse%2C%22doc%22%3Afalse%7D%7D
@vjeux vjeux added the type:bug Issues identifying ugly output, or a defect in the program label Apr 18, 2017
vjeux added a commit to vjeux/prettier that referenced this issue Apr 18, 2017
@vjeux
Fix arrow function parenthesis with comments in flow
9f2e6b0 
`leadingComment` and `trailingComment` are babylon-specific, we should use `comments` which is what prettier adds.

Fixes prettier#1335
@vjeux vjeux mentioned this issue Apr 18, 2017
Merged
vjeux added a commit that referenced this issue Apr 19, 2017
@vjeux
Fix arrow function parenthesis with comments in flow (#1339)
042e603 
`leadingComment` and `trailingComment` are babylon-specific, we should use `comments` which is what prettier adds.

Fixes #1335
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vjeux