New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"editorconfig" configuration prints an "Ignored unknown option" warning #13539
Comments
That's an option of Prettier CLI, not something specified in a config file. |
@thorn0 So I think it should be removed from the json schema (it is the fifth property). |
Indeed, it shouldn't be there unless I'm missing something. Need to investigate. Thanks for noticing this. |
Is there any reason it cannot be specified in the config file? It actually recognizes the option if placed there. The docs makes no mention of this either https://prettier.io/docs/en/configuration.html#editorconfig |
Why isn't this an option in .prettierrc? It would make sense that CLI flags roughly match config file options. |
Move it from `.prettierrc.yaml` to CLI arguments, see prettier/prettier#13539 Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
* ci: run `prettier --check .` * chore: fix prettier's option `editorconfig` Remove it from `.prettierrc.yaml`, it seems to be enabled by default. See also prettier/prettier#13539 Signed-off-by: Miroslav Bajtoš <oss@bajtos.net> * ignore `target` files (Rust build outputs) --------- Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
This problem has been bothering me for some time. If I set But the ci check |
Can a prettier maintainer please address this issue? It doesn't make sense to be a cli option but not in the config file. Is the Are you open to PR to remove the warning and update the docs? |
I'm finding that "editorconfig" is not respected in |
Adding
{ "editorconfig": true }
to the configuration file, although it works, but prints[warn] Ignored unknown option { editorconfig: true }.
(multiple times).Environments:
Steps to reproduce:
Add
{ "editorconfig": true }
to.prettierrc.json
and run prettier.Expected behavior:
No warn message is printed.
Actual behavior:
This message is printed (multiple times):
[warn] Ignored unknown option { editorconfig: true }.
The text was updated successfully, but these errors were encountered: