Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular templates self closing tags #14168

Closed
SebastianPodgajny opened this issue Jan 12, 2023 · 2 comments · Fixed by #14170
Closed

Angular templates self closing tags #14168

SebastianPodgajny opened this issue Jan 12, 2023 · 2 comments · Fixed by #14170
Assignees
@fisker
Labels
lang:angular Issues affecting Angular template (not general JS/TS issues used for Angular) locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:bug Issues identifying ugly output, or a defect in the program

Comments

@SebastianPodgajny
Copy link

Prettier 2.8.2
Playground link

Input:

<app-test/>

Output:

SyntaxError: Only void and foreign elements can be self closed "app-test" (1:1)
> 1 | <app-test/>
    | ^^^^^^^^^
  2 |

Expected behavior:
In Angular 15.1.0 developers are allowed to use self closed tags for custom elements angular/angular#48535
Prettier should support this feature
@kachkaev kachkaev added lang:angular Issues affecting Angular template (not general JS/TS issues used for Angular) type:bug Issues identifying ugly output, or a defect in the program labels Jan 12, 2023
@robertIsaac robertIsaac mentioned this issue Jan 12, 2023
Closed
@fisker fisker self-assigned this Jan 13, 2023
@fisker fisker mentioned this issue Jan 13, 2023
Merged
4 tasks
@ValentinKrigovsky ValentinKrigovsky mentioned this issue Jan 13, 2023
Closed
@fisker fisker pinned this issue Jan 13, 2023
fisker added a commit that referenced this issue Jan 14, 2023
@fisker
Angular: allow self-closing tags on custom elements (#14170)
4ad9160 
Fixes #14168
@fisker
Copy link
Sponsor Member

fisker commented Jan 14, 2023

Will make a release today.

@fisker
Copy link
Sponsor Member

fisker commented Jan 14, 2023

Done https://github.com/prettier/prettier/releases/tag/2.8.3

@fisker fisker unpinned this issue Jan 14, 2023
@HymanZHAN HymanZHAN mentioned this issue Mar 5, 2023
Closed
@github-actions github-actions bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Nov 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2023
medikoo pushed a commit to medikoo/prettier-elastic that referenced this issue Jan 4, 2024
@fisker @medikoo
Angular: allow self-closing tags on custom elements (prettier#14170)
f8ac810 
Fixes prettier#14168
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fisker fisker

Labels
lang:angular Issues affecting Angular template (not general JS/TS issues used for Angular) locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Angular: allow self-closing tags on custom elements fisker/prettier
3 participants
@fisker @kachkaev @SebastianPodgajny