Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4 Release #1722

Closed
10 of 15 tasks
vjeux opened this issue May 25, 2017 · 8 comments
Closed
10 of 15 tasks

1.4 Release #1722

vjeux opened this issue May 25, 2017 · 8 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Comments

@vjeux
Copy link
Contributor

vjeux commented May 25, 2017

Starting this issue to track what needs to be done for the 1.4 release:

TypeScript support:

TypeScript formatting blockers:

Facebook blockers:

Things that are easy we should knock down:

It's going to be pretty awesome :)

@vjeux
Copy link
Contributor Author

vjeux commented Jun 2, 2017

https://github.com/prettier/prettier/releases/tag/1.4.0

@azz
Copy link
Member

azz commented Jun 2, 2017

@vjeux Should we mention in the Readme/release that TypeScript 2.3 is required? (this is a requirement of typescript-eslint-parser)

@vjeux
Copy link
Contributor Author

vjeux commented Jun 2, 2017

I'm now bundling everything so prettier is now dependency-free. https://unpkg.com/prettier@1.4.0/src/

@JamesHenry
Copy link
Collaborator

JamesHenry commented Jun 4, 2017

TypeScript is a peerDependency of the parser, so I think @azz's point still stands, @vjeux. The first step in the process is that the code is parsed using the TypeScript compiler, so it does have to be there and the version is important in various cases.

TypeScript 2.3 is the supported "major" version (based on how TS handles version numbers), typescript-eslint-parser will log a warning to the console if another version is being used.

I think the simplest thing would be to link to this: https://github.com/eslint/typescript-eslint-parser#supported-typescript-version

@vjeux
Copy link
Contributor Author

vjeux commented Jun 4, 2017

@JamesHenry The npm version of prettier has 0 dependencies. I'm bundling all the dependencies in a single parser-typescript.js file that includes typescript 2.3, typescript-eslint-parser, all their dependencies... This way, you can just drop in prettier and "it just works".

@JamesHenry
Copy link
Collaborator

Ah, I see, TypeScript is also included in that - that's awesome 😄

Is the TS version that's bundled dictated by the devDependency of this project?

@vjeux
Copy link
Contributor Author

vjeux commented Jun 4, 2017

@JamesHenry
Copy link
Collaborator

Great 👍 I'll make sure that gets updated as and when the stable version of TypeScript changes

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

3 participants