-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.4 Release #1722
Comments
@vjeux Should we mention in the Readme/release that TypeScript 2.3 is required? (this is a requirement of typescript-eslint-parser) |
I'm now bundling everything so prettier is now dependency-free. https://unpkg.com/prettier@1.4.0/src/ |
TypeScript is a peerDependency of the parser, so I think @azz's point still stands, @vjeux. The first step in the process is that the code is parsed using the TypeScript compiler, so it does have to be there and the version is important in various cases. TypeScript 2.3 is the supported "major" version (based on how TS handles version numbers), I think the simplest thing would be to link to this: https://github.com/eslint/typescript-eslint-parser#supported-typescript-version |
@JamesHenry The npm version of prettier has 0 dependencies. I'm bundling all the dependencies in a single |
Ah, I see, TypeScript is also included in that - that's awesome 😄 Is the TS version that's bundled dictated by the devDependency of this project? |
Great 👍 I'll make sure that gets updated as and when the stable version of TypeScript changes |
Starting this issue to track what needs to be done for the 1.4 release:
TypeScript support:
TypeScript formatting blockers:
Facebook blockers:
import from
for a single one like we do forrequire
Things that are easy we should knock down:
It's going to be pretty awesome :)
The text was updated successfully, but these errors were encountered: