Pasting an array inserts a semicolon

[jdhines]

This doesn't reproduce in the playground, but in VS Code, if I disable every extension except Prettier, I see this issue, and if I disable Prettier, there is no semicolon insertion.

Input:

let myThings = {
  group1: [1,2,3],
  group2: [1,2],
  thing: ''
}

And if I copy [1,2,3] from the first item, select [1,2] or '' in the second or third item and paste, it inserts a semicolon after the closing bracket:
Output:

let myThings = {
  group1: [1,2,3],
  group2: [1, 2, 3];,
  thing: ''
}
//OR
let myThings = {
  group1: [1,2,3],
  group2: [1,2],
  thing: [1, 2, 3];
}

Expected behavior:
Pasting an array doesn't automatically add a semicolon at the end

[ikatyang]

It looks similar to prettier/prettier-vscode#257, and I'm not able to reproduce, can you provide your versions/settings?

[jdhines]

It does seem similar, but I don't get that exact issue either, just when pasting an array. I'm on version 1.0.1 of prettier-vscode, which is Prettier 1.9. All prettier-vscode settings are default, but I do have "editor.formatOnPaste": true

Even if I set "prettier.semi": false it still adds the semicolon

[azz]

/cc @CiGit @josephfrazier

[CiGit]

Format on paste calls the range formatter.

$ cat test.js
let myThings = {
    group1: [1,2,3],
    group2: [1,2],
    thing: ''
}
$ npx prettier@1.5 --range-start 50 --range-end 55 test.js
let myThings = {
  group1: [1, 2, 3],
  group2: [1, 2],
  thing: ""
};
$ npx prettier@1.7 --range-start 50 --range-end 55 test.js # [1.6 - 1.7]
let myThings = {
    group1: [1,2,3],
    group2: [1, 2];,
    thing: ''
}
$ npx prettier@1.8 --range-start 50 --range-end 55 test.js # [1.8 - latest]
let myThings = {
  group1: [1, 2, 3],
  group2: [1, 2],
  thing: ""
};

I suppose you have a prettier installed locally (range 1.6 - 1.7) which is the one taken by the extension.

Over Prettier(Bottom right your editor) after having called the formatter to see which version it picked up.

[azz]

Thanks for looking into that @CiGit.

I'll close this issue as it was probably fixed in #3069 which was in 1.8.

Re-open if this is not the case.

[jdhines]

prettier@1.7.4
I see I do have that in my package.json
If I have the VS Code plugin, should I remove it from my project? Or should I just make sure the version in my project is updated?

[azz]

Just update your local prettier to 1.9