Split source elements relative to their language. #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colliding node types which are not source elements in every language. Example ObjectExpression in JSON / JS
CiGit
commented
Oct 19, 2017
index.js
Outdated
| case "flow": | ||
| case "babylon": | ||
| case "typescript": | ||
| return jsSourceElements.includes(node.type); |
There was a problem hiding this comment.
Let's end tests, but I'm not sure .includes is in node 4...
CiGit
commented
Oct 19, 2017
| case "ScalarTypeDefinition": // GraphQL | ||
| return true; | ||
| // JS and JS like to avoid repetitions | ||
| const jsSourceElements = [ |
There was a problem hiding this comment.
What's the rule with global variables? those const ...SourceElements could be defined outside.
azz
requested changes
Oct 20, 2017
| a: 1, | ||
| },<<<PRETTIER_RANGE_START>>> | ||
| { | ||
| a: 1, |
There was a problem hiding this comment.
Could you add an additional property to this object? Otherwise it could be treated as a block + label.
There was a problem hiding this comment.
Right, it's certainly clearer than trying to find a semicolon {a: 1;}.
Done.
ObjectExpression vs BlockStatement & LabeledStatement
josephfrazier
approved these changes
Oct 21, 2017
| case "UnionTypeDefinition": // GraphQL | ||
| case "ScalarTypeDefinition": // GraphQL | ||
| return true; | ||
| // JS and JS like to avoid repetitions |
There was a problem hiding this comment.
Is this supposed to be "JS and TS like to avoid repetitions"?
There was a problem hiding this comment.
I interpreted as JS-like = flow, TypeScript.
|
Oh, that makes more sense. I had overlooked "like".
|
azz
approved these changes
Oct 22, 2017
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3068 : Colliding node types which are not source elements in every language.
Example:
ObjectExpressionin JSON / JSSource Elements are now based on the parser.